wohali commented on a change in pull request #1470: Fix calculation of external
size for attachments
URL: https://github.com/apache/couchdb/pull/1470#discussion_r235796634
##########
File path: src/couch/src/couch_db.erl
##########
@@ -914,7 +914,18 @@ prep_and_validate_update(Db, #doc{id=Id,revs={RevStart,
Revs}}=Doc,
% new doc, and we have existing revs.
% reuse existing deleted doc
if OldFullDocInfo#full_doc_info.deleted orelse AllowConflict ->
- {validate_doc_update(Db, Doc, fun() -> nil end), Doc};
+ case couch_doc:has_stubs(Doc) of
+ true ->
+ #full_doc_info{rev_tree=RevTree} = OldFullDocInfo,
+ Leafs = couch_key_tree:get_all_leafs(RevTree),
+ [{Leaf, DiskRevs} | _] = lists:reverse(Leafs),
Review comment:
@eiri two questions:
1) Will this be ready in the next few days?
2) Are you subscribed to [email protected] and seeing my regular
emails about the 2.3.0 milestone?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services