wohali commented on a change in pull request #1721: Copy _security object in 
couchup; python3 fix
URL: https://github.com/apache/couchdb/pull/1721#discussion_r231681590
 
 

 ##########
 File path: rel/overlay/bin/couchup
 ##########
 @@ -172,6 +172,25 @@ def _put_filter(args, db=None):
             print(exc.response.text)
             exit(1)
 
+def _do_security(args, db=None):
 
 Review comment:
   No, but some of the other functions that have the same calling function also 
don't check this parameter, see `_put_filter` for instance.
   
   So that's not great, BUT if you look down at `_replicate`, it's doing a `for 
db in dbs` so a `None` shouldn't end up in that list anyway.
   
   You're welcome to improve the code if you like in a new PR :smile: 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to