garrensmith commented on a change in pull request #1709: Support out-of-sync
between db and index in mango
URL: https://github.com/apache/couchdb/pull/1709#discussion_r231034792
##########
File path: src/mango/src/mango_cursor_view.erl
##########
@@ -427,7 +435,10 @@ doc_member(Cursor, RowProps) ->
match_doc(Selector, Doc, ExecutionStats1);
Else ->
Else
- end
+ end;
+ null ->
Review comment:
What about instead just returning `{no_match, null, {execution_stats,
ExecutionStats1}}` here. Then we don't need to add in the `{ok, null, Stats}`
clause in the `handle_message` function? It seems unnessecary to handle this
cause separately everywhere. Rather handle it in one place and simplify it down
to a `no_match`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
