nickva commented on a change in pull request #1658: Enable cluster
auto-assembly through a seedlist
URL: https://github.com/apache/couchdb/pull/1658#discussion_r228259299
##########
File path: src/mem3/src/mem3_rpc.erl
##########
@@ -41,6 +43,11 @@
-include("mem3.hrl").
-include_lib("couch/include/couch_db.hrl").
+% "Pull" is a bit of a misnomer here, as what we're actually doing is
+% issuing an RPC request and telling the remote node to push updates to
+% us. This lets us reuse all of the battle-tested machinery of mem3_rpc.
+pull_from_seed(Seed) ->
Review comment:
This seems useful in general and maybe rename this to pull_replication so it
matches with the pull_replication_rpc local callback?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
