popojargo commented on a change in pull request #1120: Use relative pathname
instead of static pathname for local replication
URL: https://github.com/apache/couchdb-fauxton/pull/1120#discussion_r207996013
##########
File path: app/addons/replication/__tests__/helpers.tests.js
##########
@@ -15,11 +15,11 @@ import helpers from '../helpers';
describe('Replication Helpers - getDatabaseLabel', () => {
it('returns database name for string', () => {
- const db = 'http://tester:[email protected]/fancy/db/name';
+ const db = 'http://tester:[email protected]/db/fancy%2Fdb%2Fname';
const res = helpers.getDatabaseLabel(db);
- expect(res).toBe('fancy/db/name');
+ expect(res).toBe('fancy%2Fdb%2Fname');
Review comment:
We have to pass the database name encoded otherwise it's hard to extract the
database name with relative urls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
