popojargo commented on a change in pull request #1062: Remove JQuery usage from
config addon
URL: https://github.com/apache/couchdb-fauxton/pull/1062#discussion_r173639326
##########
File path: app/addons/config/components.js
##########
@@ -248,13 +252,12 @@ class ConfigOptionTrash extends React.Component {
render() {
return (
- <td className="text-center config-item-trash config-delete-value"
- onClick={this.showModal.bind(this)}>
- <i className="icon icon-trash"></i>
+ <td className="text-center config-item-trash config-delete-value">
+ <i className="icon icon-trash" onClick={this.showModal}></i>
Review comment:
Any reason to move the onClick handler to <i> instead of <td>?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
