wohali commented on issue #1200: [DISCUSS] CouchDB Request Size Limits URL: https://github.com/apache/couchdb/pull/1200#issuecomment-370164647 OK, I've had a read through. Looks good, though I have some comments. In 2.2.0, shouldn't we raise the default `max_http_request_size` or reduce the default `max_document_size` so the default configuration doesn't end up with docs too big to replicate? We should support `infinity` as a valid value for all of these `max_*` settings. We already do support `infinity for `max_attachment_size`. We should enforce `max_attachment_* = 0` on the node-local port. We can either ignore, mirror, or hard-code the other limits on the node-local port. (And we should keep moving towards removing the node-local port entirely for 3.0.) I am +1 on the idea of setting `max_attachments_per_doc = 0` to disable attachments, and documenting this as a feature. We can even include text about it improving CouchDB performance, and point people at recommended external solutions for binary management if desired, especially if this is a pattern we are actively trying to discourage. I am -0 on `local.ini-recommended`, as I feel our defaults should already be the recommendations, for any release. If those settings can't yet be the default (as they would be in 2.2.0 vs. 3.0.0) then we should stick them in `local.ini` and just comment them out. People are already used to un-commenting lines in `local.ini` for things they want, let's continue with that pattern. The only way I'd think `local.ini-*` files would make sense is if we wanted to start shipping different settings for different standard configurations: standalone node, 3-node cluster, db-per-user setups, etc. and that's still a bit of a bandaid. (The Debian packaging attempts to hide this type of configuration from the user; why not remove the smarts from the package and stick them right in the product instead? This is well beyond the scope of this PR.) As a side-note, I'd like to move towards any (and all?) `default.ini` settings to be commented out, meaning the file is effectively empty for a new install and acts almost as documentation. We see in the field plenty of people who keep their old `default.ini` files around - this is especially a problem with the older `Docker` containers - so it'd be nice to eliminate that problem. I know this is challenging for our handler definitions right now, but at least numerical settings like these `max_*` settings could be resolved.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
