davisp commented on a change in pull request #1186: [WIP] Clustered purge mixed
cluster upgrade
URL: https://github.com/apache/couchdb/pull/1186#discussion_r171619458
##########
File path: src/couch/src/couch_bt_engine.erl
##########
@@ -759,6 +777,45 @@ set_default_security_object(Fd, Header, Compression,
Options) ->
end.
+% This function is to rollback pf clustered purge.
+% It replaces purge_tree_state and upurge_tree_state with
+% with purged_docs disk pointer that stores only the last purge request
Review comment:
This function is wrong as its not a mirror of what happens when we upgrade
the state turning the whole purge docs into multiple rows. It also occurs to me
that we transform this in such a way that we'd not be able to know how to undo
the upgrade since we would not be able to distinguish between an upgrade and
purges applied after the upgrade.
Also if we rollback this approach would also likely invalidate all secondary
indices since we're grabbing the last purge sequence as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
