garrensmith commented on a change in pull request #1043: Upgrade to eslint v4
and enable recommended lint rules
URL: https://github.com/apache/couchdb-fauxton/pull/1043#discussion_r159371817
##########
File path: .eslintrc
##########
@@ -22,14 +21,17 @@
"comma-spacing": [2, {"before": false, "after": true}],
"computed-property-spacing": [2, "never"],
"eol-last": 2,
+ "no-case-declarations": 0,
+ "no-console": [1, { "allow": ["warn", "error", "info"] }],
"no-mixed-spaces-and-tabs": [2, "smart-tabs"],
"no-trailing-spaces": 2,
"semi-spacing": [2, {"before": false, "after": true}],
- "no-empty": 2,
"space-in-parens": [2, "never"],
+ "space-unary-ops": 2,
"no-unused-vars": [2, {"varsIgnorePattern": "ReactDOM"}],
- "react/jsx-uses-vars": 2,
- "react/jsx-uses-react": 2
+ "react/display-name": 0,
+ // disabling for now since there are too many components without PropTypes
+ "react/prop-types": 0
Review comment:
I'm not sure if this is all ready in the rules that we inherit from but
should we set line spacing to 2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
