popojargo commented on a change in pull request #1036: move revision browser to
use redux
URL: https://github.com/apache/couchdb-fauxton/pull/1036#discussion_r158586164
##########
File path: app/addons/documents/index-results/components/results/TableRow.js
##########
@@ -93,7 +93,7 @@ export default class TableRow extends React.Component {
}
return (
- <td className="tableview-el-last" onClick={this.onClick}>
+ <td className="tableview-el-last" onClick={this.onClick.bind(this)}>
Review comment:
Shouldn't you bind the onClick in the constructor to be more optimal?
Binding in render() functions will be called for each render(which is not
optimal).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
