eiri commented on a change in pull request #1078: Refactor couch_log.erl URL: https://github.com/apache/couchdb/pull/1078#discussion_r158010510
########## File path: src/couch_log/src/couch_log.erl ########## @@ -82,6 +66,7 @@ set_level(Level) -> -spec log(atom(), string(), list()) -> ok. log(Level, Fmt, Args) -> + couch_stats:increment_counter([couch_log, level, Level]), Review comment: Wrong place. You need to move it inside of `true` clause down here, to not count un-called log messages for severity below a threshold. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
