kxepal commented on a change in pull request #995: WIP: improve Mango test
suite performance
URL: https://github.com/apache/couchdb/pull/995#discussion_r151095022
##########
File path: src/mango/test/01-index-crud-test.py
##########
@@ -193,7 +193,7 @@ def test_recreate_index(self):
pre_indexes = self.db.list_indexes()
for i in range(5):
ret = self.db.create_index(["bing"], name="idx_recreate")
- assert ret is True
+ self.assertTrue(ret)
Review comment:
`self.assertIs` is better. This assertion will be passed if ret would be not
just `True`, but `"1"`, `42`, `["ololo"]`, e.g. any non-falsy value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
