nickva commented on issue #756: Make couch_peruser a proper Erlang app URL: https://github.com/apache/couchdb/pull/756#issuecomment-335366388 Great work, @janl ! Cleanups, readme and default.ini look great. I compiled it, enabled it, added a user and it auto-created their respective db. See a few comments about issues I noticed, otherwise it's looking nice: I got a an exception when I set a config option ``` rpc:multicall(config, set, ["couch_peruser", "deletedbs", "true"]). {[ok,ok,ok],[]} ``` ``` gen_server couch_peruser terminated with reason: bad record changes_state at couch_peruser:'-exit_changes/1-fun-0-'/2(line:285) <= lists:foreach/2(line:1338) <= couch_peruser:handle_cast/2(line:328) <= gen_server:try_dispatch/4(line:601) <= gen_s erver:handle_msg/5(line:667) <= proc_lib:init_p_do_apply/3(line:247) last msg: {config_change,"couch_peruser","deletedbs","true",true} ``` It's from a mismatched state record. See comment above in exit changes And one about `handle_info({'DOWN'...)` Some stylistic pedantry: some lines are > 80 columns, maybe that's how it it was already but at least for new code consider reformatting a bit to keep the lines shorter. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
