rnewson commented on a change in pull request #862: Whitelist system DB names
as valid _dbs docids
URL: https://github.com/apache/couchdb/pull/862#discussion_r142641709
##########
File path: src/couch/src/couch_doc.erl
##########
@@ -126,8 +128,11 @@
doc_to_json_obj(#doc{id=Id,deleted=Del,body=Body,revs={Start, RevIds},
}.
from_json_obj_validate(EJson) ->
+ from_json_obj_validate(EJson, <<"">>).
Review comment:
`undefined` atom is a safer default, I can see bugs if we allow a database
name to be the empty string even in this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
