garrensmith commented on a change in pull request #971: Refactor 
documents/mango addon to use Redux
URL: https://github.com/apache/couchdb-fauxton/pull/971#discussion_r138628562
 
 

 ##########
 File path: app/addons/documents/index-results/reducers.js
 ##########
 @@ -211,11 +222,14 @@ export const getAllDocsSelected = (state) => {
 
   for (let i = 0; i < state.docs.length; i++) {
     const doc = state.docs[i];
 
 Review comment:
   This for loop seems really complicated. Could we simplify it move by using a 
`.reduce` or `.filter`?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to