garrensmith commented on a change in pull request #971: WIP - Refactor
documents/mango addon to use Redux
URL: https://github.com/apache/couchdb-fauxton/pull/971#discussion_r136063389
##########
File path: app/addons/documents/index-results/apis/base.js
##########
@@ -24,12 +25,13 @@ export const resetState = () => {
};
};
-export const newResultsAvailable = (docs, params, canShowNext) => {
+export const newResultsAvailable = (docs, params, canShowNext, docType) => {
Review comment:
I've been wondering about this. I don't think we should have any `action`
functions in the api. The `api` files should just do ajax queries and be a
basic api to interact with CouchDB. I don't think the `api's` should know about
redux or anything like that. They should just pass data and then the action
functions in the `action.js` files should do any required dispatching. What do
you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
