willholley commented on a change in pull request #768: basic execution 
statistics for _find
URL: https://github.com/apache/couchdb/pull/768#discussion_r134672259
 
 

 ##########
 File path: src/mango/src/mango_execution_stats.hrl
 ##########
 @@ -0,0 +1,17 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
+% use this file except in compliance with the License. You may obtain a copy of
+% the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+% License for the specific language governing permissions and limitations under
+% the License.
+
+-record(execution_stats, {
 
 Review comment:
   @tonysun83 ideally the key lookup counter would be as you describe - it's 
just not implemented that way yet (code assumes key lookups == doc lookups 
until we have covering indexes). Note that the current counters don't say 
anything about the number of rows returned - just the number of internal row / 
document fetches.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to