garrensmith commented on a change in pull request #933: Update for changes to
_cluster_setup endpoint
URL: https://github.com/apache/couchdb-fauxton/pull/933#discussion_r128966300
##########
File path: app/addons/setup/setup.js
##########
@@ -66,6 +99,32 @@ var SetupCurrentAdminPassword = React.createClass({
});
+var SetupNodeCountSetting = React.createClass({
+ getInitialState: function () {
+ return {
+ nodeCountValue: this.props.nodeCountValue
+ };
+ },
+
+ handleNodeCountChange: function (event) {
+ this.props.onAlterNodeCount(event);
Review comment:
Don't pass the whole event through. Just the value that you want changed.
Otherwise its a bit of a leaky abstraction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services