nickva opened a new pull request #679: Fix flaky os daemons tests URL: https://github.com/apache/couchdb/pull/679 Fix flaky os daemons tests The "should die" test was close to the edge of timing out. Daemon started up, slept for 1 second then died. However max_retries is 3 so the whole thing was happening 3 times in a row. The total wait was 4 seconds, but on slow machines 1 extra second was not enough for the overhead of forking the 3 processes and other setup stuff. Set restart times to 2. Hopefully 4 seconds should be enough overhead for 2 restarts. Also adjust sleep time for the "die quickly" test. 1 second there might not be enough for both restarts, so made it 2 just to be safe. Also in a separate commit, remove unused TIMEOUT macro from os daemons module ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
