davisp commented on a change in pull request #610: Optimize ddoc cache URL: https://github.com/apache/couchdb/pull/610#discussion_r125990804
########## File path: src/ddoc_cache/src/ddoc_cache.hrl ########## @@ -0,0 +1,40 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +% use this file except in compliance with the License. You may obtain a copy of +% the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +% License for the specific language governing permissions and limitations under +% the License. + +-type dbname() :: iodata(). +-type docid() :: iodata(). +-type doc_hash() :: <<_:128>>. +-type revision() :: {pos_integer(), doc_hash()}. + +-define(CACHE, ddoc_cache_entries). +-define(LRU, ddoc_cache_lru). +-define(REFRESH_TIMEOUT, 67000). +-define(SHUTDOWN_TIMEOUT, 1000). Review comment: I made REFRESH_TIMEOUT configurable and this is now just the default. SHUTDOWN_TIMEOUT is entirely too subtle to be turned into a config option. If we hit issues there then we have other problems. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
