ddanielr commented on code in PR #6049:
URL: https://github.com/apache/accumulo/pull/6049#discussion_r2867059291
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1190,15 +1220,35 @@ private List<TabletMigration>
checkMigrationSanity(Set<TabletServerId> current,
> MAX_BAD_STATUS_COUNT) {
if (shutdownServerRateLimiter.tryAcquire()) {
log.warn("attempting to stop {}", server);
- try {
- TServerConnection connection2 =
tserverSet.getConnection(server);
- if (connection2 != null) {
- connection2.halt(managerLock);
+ var gracefulHaltTimer =
tserverHaltRpcAttempts.computeIfAbsent(server,
Review Comment:
Yes but that boolean can be removed. The check was moved into the
shouldForceHalt() method where maxHaltGraceDuration.toMillis() != 0
This still provides the ability to have the behavior disabled by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
