ctubbsii commented on code in PR #5935:
URL: https://github.com/apache/accumulo/pull/5935#discussion_r2383502492
##########
core/src/main/java/org/apache/accumulo/core/iterators/user/IntersectingIterator.java:
##########
@@ -96,13 +96,6 @@ public static class TermSource {
public Collection<ByteSequence> seekColfams;
public final boolean notFlag;
- public TermSource(TermSource other) {
- this.iter = other.iter;
- this.term = other.term;
- this.notFlag = other.notFlag;
- this.seekColfams = other.seekColfams;
- }
-
Review Comment:
I think this is public API. Maybe users have a utility for this?
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/MetadataSchema.java:
##########
@@ -482,22 +482,6 @@ public static class Upgrade11to12 {
}
}
- /**
- * Contains additional metadata in a reserved area not for tablets
- */
- public static class ReservedSection {
- private static final Section section = new Section(RESERVED_PREFIX, true,
null, false);
-
- public static Range getRange() {
- return section.getRange();
- }
-
- public static String getRowPrefix() {
- return section.getRowPrefix();
- }
-
- }
-
Review Comment:
This class serves as schema documentation. We don't have a need to scan the
whole reserved range, so we don't use it directly, but it should still exist to
provide a mechanism in code to evaluate the schema of the metadata table.
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/Ample.java:
##########
@@ -135,10 +135,6 @@ public enum GcCandidateType {
* Candidates that have no matching file references and can be removed
from the system.
*/
VALID,
- /**
- * Candidates that are malformed.
- */
- INVALID
Review Comment:
I'm surprised we don't need this.
##########
core/src/main/java/org/apache/accumulo/core/iterators/user/IntersectingIterator.java:
##########
@@ -398,13 +391,6 @@ protected void advanceToIntersection() throws IOException {
topKey = buildKey(currentPartition, nullText, currentDocID);
}
- public static String stringTopKey(SortedKeyValueIterator<Key,Value> iter) {
- if (iter.hasTop()) {
- return iter.getTopKey().toString();
- }
- return "";
- }
-
Review Comment:
Probably also public API
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/RootTabletMetadata.java:
##########
@@ -97,15 +97,6 @@ private Data(int version,
TreeMap<String,TreeMap<String,String>> columnValues) {
this.columnValues = columnValues;
}
- public int getVersion() {
- return version;
- }
-
- public static boolean needsUpgrade(final String json) {
- var rootData = GSON.get().fromJson(json, Data.class);
- int currVersion = rootData.getVersion();
- return currVersion < VERSION;
- }
Review Comment:
Do we read the version from the serialized metadata elsewhere now? It seems
important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
