ctubbsii commented on code in PR #5890:
URL: https://github.com/apache/accumulo/pull/5890#discussion_r2357066036
##########
.github/workflows/maven.yaml:
##########
@@ -68,15 +68,15 @@ jobs:
- {name: 'unit-tests', javaver: 17, args: 'verify -PskipQA
-DskipTests=false'}
- {name: 'qa-checks', javaver: 17, args: 'verify javadoc:jar
-Psec-bugs -DskipTests -Dspotbugs.timeout=3600000'}
- {name: 'compat', javaver: 17, args: 'package -DskipTests
-Dversion.hadoop=3.0.3 -Dversion.zookeeper=3.5.10'}
- - {name: 'errorprone', javaver: 17, args: 'verify
-Perrorprone,skipQA'}
+ - {name: 'errorprone', javaver: 17, args: 'verify -Derrorprone
-PskipQA'}
Review Comment:
This change isn't needed for the main branch, which doesn't have
AccumuloMonitorAppender, so this won't carry forward... though I've set it up
to work either way.
##########
.github/workflows/maven.yaml:
##########
@@ -41,7 +41,7 @@ jobs:
- name: Set up JDK 17
uses: actions/setup-java@v4
with:
- distribution: adopt
+ distribution: temurin
Review Comment:
This is what main is using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]