ctubbsii commented on code in PR #5775:
URL: https://github.com/apache/accumulo/pull/5775#discussion_r2308867353
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1787,7 +1795,8 @@ public boolean testClassLoad(final String tableName,
final String className,
try {
return ThriftClientTypes.CLIENT.execute(context,
client -> client.checkTableClass(TraceUtil.traceInfo(),
context.rpcCreds(), tableName,
- className, asTypeName));
+ className, asTypeName),
+ rgid -> true);
Review Comment:
This could be put in a method, so it can have a better name:
```suggestion
ResourceGroupId::ANY;
```
Implementation would look something like:
```java
public static boolean ANY(ResourceGroupId rgid) {
return true;
}
```
or
```java
public static final Predicate<ResourceGroupId> ANY = x -> true;
```
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/InstanceOperationsImpl.java:
##########
@@ -106,7 +106,8 @@ public void setProperty(final String property, final String
value)
+ " setting its replacement {} instead", property, replacement);
});
ThriftClientTypes.MANAGER.executeVoid(context, client -> client
- .setSystemProperty(TraceUtil.traceInfo(), context.rpcCreds(),
property, value));
+ .setSystemProperty(TraceUtil.traceInfo(), context.rpcCreds(),
property, value),
+ rgid -> rgid.equals(ResourceGroupId.DEFAULT));
Review Comment:
```suggestion
ResourceGroupId.DEFAULT::equals);
```
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientTabletCacheImpl.java:
##########
@@ -677,7 +678,8 @@ private void requestTabletHosting(ClientContext context,
extentsToBringOnline.size(), tableId);
ThriftClientTypes.MANAGER.executeVoid(context,
client -> client.requestTabletHosting(TraceUtil.traceInfo(),
context.rpcCreds(),
- tableId.canonical(), extentsToBringOnline));
+ tableId.canonical(), extentsToBringOnline),
+ rgid -> rgid.equals(ResourceGroupId.DEFAULT));
Review Comment:
Small syntax improvement:
```suggestion
tableId.canonical(), extentsToBringOnline),
ResourceGroupId.DEFAULT::equals);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
