keith-turner commented on code in PR #5841: URL: https://github.com/apache/accumulo/pull/5841#discussion_r2308594651
########## .github/ISSUE_TEMPLATE/post_vote_checklist.md: ########## @@ -45,4 +45,6 @@ assignees: '' - [ ] Send to [email protected] and [email protected] (use plain text mode only; html email will be rejected) - GitHub wrap-up - [ ] Close this issue +- Code + - [ ] Update the javadoc since versions list in the `pom.xml` file for the next development branch Review Comment: This is a good way to make sure this is done for release. ########## pom.xml: ########## @@ -1030,6 +1036,19 @@ <value>org-apache-${project.artifactId}</value> </configuration> </execution> + <execution> Review Comment: This will always execute before the javadoc? ########## core/src/main/java/org/apache/accumulo/core/client/Connector.java: ########## @@ -252,7 +252,7 @@ public abstract ConditionalWriter createConditionalWriter(String tableName, * AccumuloClient is closed. Also anything derived from the Connector (like a Scanner for example) * is unlikely to work after the AccumuloClient is closed. * - * @since 2.0 + * @since 2.0.0 Review Comment: How did you find these malformed since tags? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
