DomGarguilo commented on PR #5822:
URL: https://github.com/apache/accumulo/pull/5822#issuecomment-3229331119

   Everything should be good to go here. Removed all the places that the table 
name lock was being used as well as the table name lock itself. Added a 
concurrent test case for each of the spots that the lock was removed from and 
they are all passing consistently.
   
   One thing that I noticed during developing the import test case was that if 
i tried to import multiple tables that had been exported with data into a 
single tablename, the test would fail with something like `File F0000001.rf 
does not exist in import dir` which is coming from 
[here](https://github.com/apache/accumulo/blob/501efad92bee10aad2910b0984752879d5e42322/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/PopulateMetadataTable.java#L159).
 I changed the test to import from tables exported with NO data and this 
exception is avoided and we get the `TableExistsException` as expected.
   
   I am wondering if this is expected behavior. It seems like we should be 
getting the `TableExistsException` regardless of whether we are importing from 
an export that contains data or not. I am not super familiar with the import 
code so I was hoping someone could help me look into this. From what I 
understand, it seems like the code is trying to operate on files that were 
removed/consumed from a previous thread which to me seems like we should have 
returned before getting to this point but I may be misunderstanding something 
here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to