kevinrr888 commented on code in PR #5790:
URL: https://github.com/apache/accumulo/pull/5790#discussion_r2279560229
##########
test/src/main/java/org/apache/accumulo/test/fate/FatePoolsWatcherITBase.java:
##########
@@ -171,12 +171,8 @@ protected void testIncrease1(FateStore<PoolResizeTestEnv>
store, ServerContext s
assertEquals(0, fate.getTxRunnersActive(set2));
assertEquals(numWorkersSet3, fate.getTxRunnersActive(set3));
assertEquals(numWorkersSet4, fate.getTxRunnersActive(set4));
- allAssertsOccurred = true;
- } catch (Exception e) {
- System.out.println("Failure: " + e);
} finally {
fate.shutdown(30, TimeUnit.SECONDS);
- assertTrue(allAssertsOccurred);
Review Comment:
Ahh good catch. I think my reason for introducing this allAssertsOccurred
was because I was seeing the test pass when an assertion would fail and
therefore the subsequent assertions would not occur. I also did not like this
allAssertsOccurred hack, but I wasn't sure why the test was passing with an
assertion failure.
Looking at this now, it's very obvious that this catch Exception was hiding
the assertion failure. Not sure why I had this catch to begin with...
Thanks for this fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
