keith-turner commented on code in PR #5730:
URL: https://github.com/apache/accumulo/pull/5730#discussion_r2223453883


##########
assemble/bin/accumulo-cluster:
##########
@@ -276,9 +276,9 @@ function quote() {
   exit 1
 }
 
-# call debug to print, or execute if debug is off
+# call debug to print the command only, or execute asynchronously if debug is 
off
 function debugOrRun() {
-  debug "$(quote "$@")" || "$@"
+  debug "$(quote "$@")" || ("$@") &

Review Comment:
   Not suggesting a change for this PR, just sharing something I was looking 
into.  Was wondering if we could wait where when the number of children is 
greater than some threshold.  Found this while looking into that 
https://stackoverflow.com/a/21996387.  Calling `pgrep -c` each time we start a 
new process would be N^2 type behavior though because all prev procs a listed 
each time a new one is added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to