ctubbsii commented on code in PR #5715:
URL: https://github.com/apache/accumulo/pull/5715#discussion_r2183701907
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1124,6 +1124,13 @@ private Map<String,String>
modifyPropertiesUnwrapped(String tableName,
Throwable cause = ae.getCause();
if (cause instanceof TableNotFoundException) {
throw new TableNotFoundException(null, tableName, null, ae);
+ } else if (cause instanceof ThriftTableOperationException) {
+ var ttoe = (ThriftTableOperationException) cause;
+ if (ttoe.getType() == TableOperationExceptionType.NAMESPACE_NOTFOUND) {
+ throw new TableNotFoundException(tableName, new
NamespaceNotFoundException(ttoe));
+ } else if (ttoe.getType() == TableOperationExceptionType.NOTFOUND) {
+ throw new TableNotFoundException(ttoe);
+ }
Review Comment:
I would have expected that this would have been handled elsewhere. The
ThriftTableOperationException shouldn't be directly wrapped by
AccumuloException if it's a TNFE. Do you know where this is coming from? Where
that wrapping is happening? It would probably be better to fix it closer to the
cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
