DomGarguilo commented on code in PR #5616:
URL: https://github.com/apache/accumulo/pull/5616#discussion_r2164396739
##########
server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsInfoImpl.java:
##########
@@ -237,6 +254,41 @@ public synchronized void close() {
Metrics.globalRegistry.close();
}
+ /**
+ * Description of what the function does.
+ *
+ * @param patternList Description of what this variable is, i.e.
comma-delimited regext patterns
+ * @return description of what this function returns, i.e. a predicate
+ */
+ public static MeterFilter getMeterFilter(String patternList) {
+ requireNonNull(patternList, "patternList must not be null");
+ Preconditions.checkArgument(!patternList.isEmpty(), "patternList must not
be empty");
Review Comment:
Yea it just wouldn't filter anything out. I'm just wondering if its a good
idea to throw an exception here if its empty since it doesn't break anything if
its empty, even if it doesn't make much sense to have it set that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
