arsenalzp commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2162499551
##########
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java:
##########
@@ -351,15 +347,6 @@ public void bulkRename(Map<Path,Path> oldToNewPathMap, int
poolSize, String pool
}
return null;
})));
- workerPool.shutdown();
- try {
- while (!workerPool.awaitTermination(1000L, TimeUnit.MILLISECONDS)) {}
- for (Future<Void> future : results) {
- future.get();
- }
Review Comment:
Are you sure it is necessary to block `bulkRename` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
