kevinrr888 commented on code in PR #5486:
URL: https://github.com/apache/accumulo/pull/5486#discussion_r2049424995
##########
test/src/main/java/org/apache/accumulo/test/functional/ManagerAssignmentIT.java:
##########
@@ -120,7 +120,7 @@ public void before() throws Exception {
@Test
public void test() throws Exception {
- // Confirm that the root and metadata tables are hosted
+ // Confirm that the system tables are hosted
Review Comment:
Would be nice to test all the system tables by iterating over
`AccumuloTable.values()` or similar. Seems like they are all making the same
checks, and ensures expected functionality of future system tables
##########
test/src/main/java/org/apache/accumulo/test/functional/TabletAvailabilityIT.java:
##########
@@ -43,12 +43,23 @@
import org.apache.accumulo.core.client.admin.TabletAvailability;
import org.apache.accumulo.core.data.Mutation;
import org.apache.accumulo.core.data.Range;
+import org.apache.accumulo.core.metadata.AccumuloTable;
import org.apache.accumulo.harness.AccumuloClusterHarness;
import org.apache.hadoop.io.Text;
import org.junit.jupiter.api.Test;
public class TabletAvailabilityIT extends AccumuloClusterHarness {
+ @Test
+ public void testSystemFails() throws Exception {
+ try (AccumuloClient client =
Accumulo.newClient().from(getClientProps()).build()) {
+ for (AccumuloTable t : AccumuloTable.values()) {
+ assertThrows(IllegalArgumentException.class, () ->
client.tableOperations()
+ .setTabletAvailability(t.tableName(), new Range(), HOSTED));
+ }
+ }
+ }
Review Comment:
Could try to set the system table to UNHOSTED and ensure that it throws,
then get the tablet availability after and ensure it's still HOSTED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
