ctubbsii commented on code in PR #5450:
URL: https://github.com/apache/accumulo/pull/5450#discussion_r2027549879
##########
pom.xml:
##########
@@ -412,12 +412,12 @@
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-collections4</artifactId>
- <version>4.4</version>
+ <version>4.5.0-M3</version>
Review Comment:
`-M3` indicates a prerelease milestone version, not a final version, and
should be avoided. The last final version should be used instead, which I think
is still 4.4
##########
server/manager/src/main/java/org/apache/accumulo/manager/state/SetGoalState.java:
##########
@@ -36,7 +36,15 @@ public class SetGoalState {
* Utility program that will change the goal state for the manager from the
command line.
*/
public static void main(String[] args) throws Exception {
- if (args.length != 1 || ManagerGoalState.valueOf(args[0]) == null) {
+ if (args.length != 1) {
+ System.err.println(
+ "Usage: accumulo " + SetGoalState.class.getName() + "
[NORMAL|SAFE_MODE|CLEAN_STOP]");
+ System.exit(-1);
+ }
+
+ try {
Review Comment:
```suggestion
try {
Preconditions.checkArgument(args.length != 1);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
