ctubbsii commented on code in PR #5423:
URL: https://github.com/apache/accumulo/pull/5423#discussion_r2017698219
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientTabletCacheImpl.java:
##########
@@ -692,64 +640,136 @@ private void requestTabletHosting(ClientContext context,
}
}
- private void lookupTablet(ClientContext context, Text row, boolean retry,
- LockCheckerSession lcSession) throws AccumuloException,
AccumuloSecurityException,
- TableNotFoundException, InvalidTabletHostingRequestException {
+ private static class ReferenceCountedLock {
Review Comment:
Can you add a javadoc to explain how this is supposed to be used correctly?
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientTabletCacheImpl.java:
##########
@@ -692,64 +640,136 @@ private void requestTabletHosting(ClientContext context,
}
}
- private void lookupTablet(ClientContext context, Text row, boolean retry,
- LockCheckerSession lcSession) throws AccumuloException,
AccumuloSecurityException,
- TableNotFoundException, InvalidTabletHostingRequestException {
+ private static class ReferenceCountedLock {
+ final Lock lock = new ReentrantLock();
+ int refCount;
Review Comment:
Should this be volatile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
