ctubbsii commented on code in PR #5350:
URL: https://github.com/apache/accumulo/pull/5350#discussion_r1992473343
##########
server/base/src/main/java/org/apache/accumulo/server/conf/store/impl/ZooPropStore.java:
##########
@@ -85,33 +83,28 @@ public class ZooPropStore implements PropStore,
PropChangeListener {
} else {
this.cache = new
PropCacheCaffeineImpl.Builder(propLoader).forTests(ticker).build();
}
-
try {
- var path = ZooUtil.getRoot(instanceId);
- if (zrw.exists(path, propStoreWatcher)) {
- log.debug("Have a ZooKeeper connection and found instance node: {}",
instanceId);
+ if (zrw.exists("/", propStoreWatcher)) {
Review Comment:
In this case, I think it's not particularly useful for checking whether `/`
exists (it can't not exist). So, whatever this code is trying to do, maybe it
can be done differently than this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
