ddanielr commented on code in PR #5391:
URL: https://github.com/apache/accumulo/pull/5391#discussion_r1988321475


##########
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##########
@@ -368,6 +379,11 @@ public void 
deleteConfirmedCandidates(SortedMap<String,GcCandidate> confirmedDel
       };
 
       deleteThreadPool.execute(deleteTask);
+      if (timer.hasElapsed(Duration.ofMinutes(1))) {
+        log.info("Batch {} deleting file {} of {}", batchCount.get(), 
deleteCounter,

Review Comment:
   ThreadPoolExecutor extends AbstractExecutorService so I just changed the 
returned object so the cast wasn't needed. 
   
   Turns out `getCompletedTaskCount()` already exists which returns an 
estimated task completion value.
   This should be close enough for our purposes and removes the need for 
additional tracking code. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to