ddanielr commented on code in PR #5293:
URL: https://github.com/apache/accumulo/pull/5293#discussion_r1934741827


##########
core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java:
##########
@@ -502,7 +520,36 @@ public ColumnVisibility(Text expression) {
    * @see #ColumnVisibility(String)
    */
   public ColumnVisibility(byte[] expression) {
-    validate(expression);
+    this(expression, true);
+  }
+
+  /**
+   * Creates a column visibility for a mutation from a string already encoded 
in UTF-8 bytes. Allows
+   * validation to be skipped for use with accumulo-access AccessExpressions
+   *
+   * @param expression visibility expression, encoded as UTF-8 bytes
+   * @param validate enables or disables validation and parse tree generation
+   */
+  private ColumnVisibility(byte[] expression, boolean validate) {

Review Comment:
   need to change the `validate` variable name to avoid conflicting with the 
`validate` method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to