keith-turner commented on code in PR #5292:
URL: https://github.com/apache/accumulo/pull/5292#discussion_r1932925311


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ZookeeperLockChecker.java:
##########
@@ -46,7 +48,14 @@ public boolean isLockHeld(String tserver, String session) {
 
   @Override
   public void invalidateCache(String tserver) {
-    zc.clear(root + "/" + tserver);
+    String serverPath = root + "/" + tserver;

Review Comment:
   The existing code would clear the children and data related to the ZK node 
`root + "/" + tserver`.  The new code here  will only clear the data for a 
specific node and not the children.  The lock checking algorithm relies on the 
children and data, so clearing both seems like the right thing to do if we want 
to force rechecking a tablet servers lock.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to