ctubbsii commented on issue #5196: URL: https://github.com/apache/accumulo/issues/5196#issuecomment-2553303358
@ddanielr wrote: > What do you think of the current options ... ? 1. :-1: this requires us to mind-read users to protect them from themselves and seems like a losing game for everybody 2. :+1: this seems best because it directly addresses the issue by more thoroughly vetting the user input; I'm not sure what current ability you're referring to; it looks like we're just throwing the rest of the args away at the end of `parse_args`, so I don't think we'd lose anything with this 3. :-1: this doesn't directly address the problem of users' input not being fully validated, and only narrowly fixes the situation indirectly via a breaking change that imposes a new option on users > can you think of any other code-based alternatives? I did have an idea to combine the two sections that parse parameters, so instead of pulling the command off before `getopt`, we do it after. That'd be the best place to do any validation of the non-option parameters, like your **Option 2**, and make sure there is exactly one (for the command to be executed). A beneficial side effect of this is that the command would no longer need to be first on the command-line. You could do things like: `accumulo-cluster --all start`. This suggestion doesn't replace your **Option 2**, but it complements it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
