ddanielr commented on code in PR #5133:
URL: https://github.com/apache/accumulo/pull/5133#discussion_r1870029881
##########
core/src/main/java/org/apache/accumulo/core/fate/zookeeper/ZooCache.java:
##########
@@ -206,6 +209,7 @@ public ZooCache(ZooReader reader, Watcher watcher) {
this.zReader = reader;
nodeCache = new ConcurrentHashMap<>();
this.externalWatcher = watcher;
+ log.trace("{} created new cache", cacheId, new Exception());
Review Comment:
Why do you want to add an exception here?
##########
core/src/main/java/org/apache/accumulo/core/fate/zookeeper/ZooCache.java:
##########
@@ -150,7 +153,7 @@ private class ZCacheWatcher implements Watcher {
@Override
public void process(WatchedEvent event) {
if (log.isTraceEnabled()) {
- log.trace("{}", event);
+ log.trace("{} {}", cacheId, event);
Review Comment:
Add colon for easier parsing
```suggestion
log.trace("{}: {}", cacheId, event);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
