keith-turner commented on code in PR #5019:
URL: https://github.com/apache/accumulo/pull/5019#discussion_r1823372745
##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader12to13.java:
##########
@@ -114,6 +118,8 @@ public void upgradeMetadata(ServerContext context) {
removeCompactColumnsFromTable(context, AccumuloTable.METADATA.tableName());
LOG.info("Removing bulk file columns from metadata table");
removeBulkFileColumnsFromTable(context,
AccumuloTable.METADATA.tableName());
+ LOG.info("Removing problems reports from metadata table");
+ removeMetadataProblemReports(context);
Review Comment:
It would be tricky to require no problem reports because some are in the
metadata table and some are in zookeeper. To read the metadata table we need
to upgrade zookeeper, so problem reports in the metadata table would only be
seen after upgrading ZK. Would not want to fail after partially upgrading when
detecting problem reports. So will look in to logging them. May need to bring
back the code to deserialize them, could put that in upgrade code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
