milleruntime commented on a change in pull request #401: Fix ChaoticBalancerIT
URL: https://github.com/apache/accumulo/pull/401#discussion_r175145145
 
 

 ##########
 File path: 
test/src/test/java/org/apache/accumulo/test/functional/ChaoticBalancerIT.java
 ##########
 @@ -42,6 +42,7 @@ public void configureMiniCluster(MiniAccumuloConfigImpl cfg, 
Configuration hadoo
     Map<String,String> siteConfig = cfg.getSiteConfig();
     siteConfig.put(Property.TSERV_MAXMEM.getKey(), "10K");
     siteConfig.put(Property.TSERV_MAJC_DELAY.getKey(), "0");
+    siteConfig.put(Property.TABLE_LOAD_BALANCER.getKey(), 
ChaoticLoadBalancer.class.getName());
 
 Review comment:
   So if you look closely at the ChoaticBalancer, it is looping over all 
tables.  And then looking at the git history of the test, it makes sense that 
it was created to test across all tables.  I think setting it to balance for 
certain table is what was also causing problems.  
   
   If we want to test per table load balancing then the ChaoticBalancer needs 
to be rewritten. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to