Hello! On Thu, Aug 07, 2014 at 09:16:42AM -0400, crespin wrote:
> Hello, > > In ngx_epoll_module.c, nevents is defined as ngx_uint_t and ev->index is > also a ngx_uint_t. > So I proposed to change nevents type. > > I'm not sure about variable declaration: > - ngx_int_t i, nready; > + ngx_uint_t i; > + ngx_int_t nready; > ngx_uint_t found, level; > > It's perhaps better to group variable by type: > - ngx_int_t i, nready; > + ngx_int_t nready; > + ngx_uint_t i, found, level; Yes, as per style used in nginx sources, variables are grouped by type. Additionally, types are sorted from shortest to longest. > # HG changeset patch > # User Yves Crespin<[email protected]> > # Date 1407416217 -7200 > # Node ID b71a279c696bcd18bd6b3c2845fe8e51d57ea1fd > # Parent c51d0d718b2177daaf14895840beb528e332418b > change nevents type in ngx_poll_module.c to ngx_uint_t Committed with various minor changes, thanks. -- Maxim Dounin http://nginx.org/ _______________________________________________ nginx mailing list [email protected] http://mailman.nginx.org/mailman/listinfo/nginx
