Hello! On Thu, Aug 07, 2014 at 09:08:10AM -0400, crespin wrote:
> Hello, > > here is the corresponding patch. > > regards, > > yves > > > Yes, %d here is certainly incorrect, as int and ngx_int_t sizes > > may differ. I don't think there are any platforms with poll() > > where this may cause problems, but nevertheless it's worth fixing. > > Changing this to %ui should be ok. > > # HG changeset patch > # User Yves Crespin<[email protected]> Note: missing space before "<". It's either corruption introduced by a forum interface, or a missing space in your ~/.hgrc. In either case you may want to use nginx-devel@ list for further patches, see http://nginx.org/en/docs/contributing_changes.html. > # Date 1407414744 -7200 > # Node ID c51d0d718b2177daaf14895840beb528e332418b > # Parent ab48149b77a6bdbe47a8543c339cf84deeb8e341 > use format %ui according to nevents type > > diff -r ab48149b77a6 -r c51d0d718b21 src/event/modules/ngx_poll_module.c > --- a/src/event/modules/ngx_poll_module.c Wed Aug 06 23:58:44 2014 +0900 > +++ b/src/event/modules/ngx_poll_module.c Thu Aug 07 14:32:24 2014 +0200 > @@ -268,7 +268,7 @@ > } > > ngx_log_debug2(NGX_LOG_DEBUG_EVENT, cycle->log, 0, > - "poll ready %d of %d", ready, nevents); > + "poll ready %d of %ui", ready, nevents); > > if (err) { > if (err == NGX_EINTR) { Committed with commit log modified to match style we use, and combined with other format specifier fixes from your other patch (as well as a couple of fixes in the select module). Thanks. -- Maxim Dounin http://nginx.org/ _______________________________________________ nginx mailing list [email protected] http://mailman.nginx.org/mailman/listinfo/nginx
