On Sat, 17 May 2014 15:37:31 +0100, Michael Drake wrote: > So, for example, to set the Amiga front end's scroll offset for the > window, it starts with a struct gui_window_2 (gw2), which I assume is the > main window containing all the tabs, then it goes to the bw (representing > current tab?), then the gw:
Yes, that's correct. It's a bit confused as I had one structure for everything, and then realised that wouldn't work when I added tabs. gui_window_2 probably needs a rename to make it clearer. Most of the frontend code uses gui_window_2 as that represents the window with the displayed content, and prior to tabs used to be gui_window (which is why the bw pointer is there rather than in gui_window). > I suggest that the gw2 be changed to have a pointer to a gw representing > the current tab, and add a pointer to bw entry in the gw. So to get the > scroll_y it would be: > > gw2->gw->scroll_y > > And to use the core browser_window_* functions, you'd be passing the bw > from: > > gw2->gw->bw > > Does that seem doable Chris? Yes, that seems more logical than what we have currently. Chris
