Re: [Netstack] pep8 1.3.2 issue with quantum

[Yong Sheng Gong]

But if the warning message is right, I think it is great for pep 1.3.2:
local variable 'last_indent' referenced before assignment


-----netstack-bounces+gongysh=cn.ibm....@lists.launchpad.net wrote: -----

To: "netstack@lists.launchpad.net" <netstack@lists.launchpad.net>
From: Robert Kukura
Sent by: netstack-bounces+gongysh=cn.ibm....@lists.launchpad.net
Date: 06/27/2012 06:46AM
Subject: [Netstack] pep8 1.3.2 issue with quantum

Version 1.3.2 of pep8, which according to
http://pypi.python.org/pypi/pep8, was released earlier today, seems to
be breaking with quantum:


[TOX] /home/rkukura/OpenStack/scm/quantum$ .tox/pep8/bin/pep8 --repeat
--show-source --exclude=.venv,.tox,dist,doc .
Traceback (most recent call last):
  File ".tox/pep8/bin/pep8", line 9, in <module>
    load_entry_point('pep8==1.3.2', 'console_scripts', 'pep8')()
  File
"/home/rkukura/OpenStack/scm/quantum/.tox/pep8/lib/python2.7/site-packages/pep8.py",
line 1916, in _main
    report = pep8style.check_files()
  File
"/home/rkukura/OpenStack/scm/quantum/.tox/pep8/lib/python2.7/site-packages/pep8.py",
line 1585, in check_files
    self.input_dir(path)
  File
"/home/rkukura/OpenStack/scm/quantum/.tox/pep8/lib/python2.7/site-packages/pep8.py",
line 1618, in input_dir
    runner(os.path.join(root, filename))
  File
"/home/rkukura/OpenStack/scm/quantum/.tox/pep8/lib/python2.7/site-packages/pep8.py",
line 1596, in input_file
    return fchecker.check_all(expected=expected, line_offset=line_offset)
  File
"/home/rkukura/OpenStack/scm/quantum/.tox/pep8/lib/python2.7/site-packages/pep8.py",
line 1339, in check_all
    self.check_logical()
  File
"/home/rkukura/OpenStack/scm/quantum/.tox/pep8/lib/python2.7/site-packages/pep8.py",
line 1279, in check_logical
    for result in self.run_check(check, argument_names):
  File
"/home/rkukura/OpenStack/scm/quantum/.tox/pep8/lib/python2.7/site-packages/pep8.py",
line 562, in continuation_line_indentation
    prev_indent = indent.pop() or last_indent[1]
UnboundLocalError: local variable 'last_indent' referenced before assignment
[TOX] ERROR: InvocationError: '.tox/pep8/bin/pep8 --repeat --show-source
--exclude=.venv,.tox,dist,doc .'


I have not tried to track down what file might be triggering this, but
I've been able to work around it by changing "deps = pep8" to "deps =
pep8==1.3.1" in tox.ini.

This will need to be fixed or avoided before additional patches will get
through the gate.

-Bob

--
Mailing list: https://launchpad.net/~netstack
Post to     : netstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~netstack
More help   : https://help.launchpad.net/ListHelp

-- 
Mailing list: https://launchpad.net/~netstack
Post to     : netstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~netstack
More help   : https://help.launchpad.net/ListHelp