Thanks Dan for the heads up; as mentioned on the IRC, we are looking at it. Also am signed up for the review.
~Sumit. From: netstack-bounces+snaiksat=cisco....@lists.launchpad.net [mailto:netstack-bounces+snaiksat=cisco....@lists.launchpad.net] On Behalf Of Dan Wendlandt Sent: Tuesday, February 28, 2012 12:41 PM To: netstack@lists.launchpad.net Subject: [Netstack] important bug fix to review Hi folks, please take a look at this review ASAP: https://review.openstack.org/#change,4647 Basically, some plugins where not enforcing that a network was owned by the tenant making the query. Also, Cisco plugin team. The Cisco plugin uses another DB model, and its unit tests weren't working for me, so I wasn't able to check if this bug affects your plugin. Please look into this ASAP. Dan Commit Msg: Fix some plugins that don't check that nets + ports are owned by tenant bug 942713 <https://code.launchpad.net/bugs/942713> . This bug confuses the validate_networks() method of QuantumManager in Nova, causing it to believe that it is valid for a tenant to plug into a particular network when in fact that network is not owned by the tenant, nor the "provider". The patch also adds unit tests to confirm correct plugin behavior. This patch fixes the issue for the Sample Plugin, the OVS plugin, the Linux Bridge plugin, and the Ryu plugin, all of which has the same DB model. Validated the fix with the unit tests. I couldn't run the unit tests for the NVP plugin standalone, but by inspection, the code seems to handle this case. I wasn't able to run the Cisco plugin unit tests, and that code uses its own DB model, so I am uncertain whether this issue exists in that plugin. -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks: www.nicira.com twitter: danwendlandt ~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
