will resubmit. thanks. dan
On Tue, Jan 24, 2012 at 4:20 PM, Monty Taylor <mord...@inaugust.com> wrote: > Hey! > > I actually think we can leave nose and pep8 out of the install_requires > as well, since that's really only going to get used by pip. BUT - it's > not going to hurt anything. > > Monty > > On 01/24/2012 04:16 PM, Dan Wendlandt wrote: > > Hi Monty, > > > > Here's a patch to remove what I believe are the unneeded dependencies. > > > > https://review.openstack.org/3379 > > > > There were a couple of cases in the main quantum repo where pip-requires > > includes a package, but the requires variable in setup.py does not. For > > example: nosexcover . I followed the same convention in the case of > > python-quantumclient. > > > > I also think its silly that we need to depend on paste, but I think > > we'll have to live with that quirk due to the fact that quantum.common > > imports it (though it shouldn't ever actually be used). > > > > I'm also not sure if a couple packages are needed, as I don't see them > > imported either by quantum or quantum-client. I removed simplejson from > > python-quantumclient, as it wasn't imported. I was less sure about > > 'tissue', so I left that in python-quantumclient. distribute as well. > > Hopefully folks who know more about the testing infrastructure can let > > me know if those dependencies are needed or not. > > > > Dan > > > > > > > > -- > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Dan Wendlandt > > Nicira Networks: www.nicira.com <http://www.nicira.com> > > twitter: danwendlandt > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks: www.nicira.com twitter: danwendlandt ~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
