On Tue, Oct 18, 2011 at 1:42 PM, Brad Hall <b...@nicira.com> wrote: > Hey Everyone, > > Since the change to make the create() calls take a parameter of k/v > pairs has gotten approval I wanted to propose a change to make the > update calls do the same. The review is here: > https://review.openstack.org/#change,929 .. I've posted this review in > order to get feedback and to have some code as a discussion starting > point. > > This has a few unfortunate consequences: > > 1) Rename_net and set_port_state .. both of these are what we had for > our "update" calls, except they weren't very generic ;) I've changed > the plugin interface to remove these calls and replace them with > generic update_port. This will break any plugins not in the tree :( > > 2) The CLI will have to change. Instead of "bin/cli rename_net <tid> > <nid> foo" we'll have to do something like "bin/cli update_net <tid> > <nid> name=foo". Does that seem reasonable? Looking for feedback > here. >
this makes sense to me. when doing this, you should take into consideration the design summit discussion about CLI extensibility, as a particular plugin may want to introduce more k-v pairs for a network or port. > > Salvatore has a proposal out for changing the API to be more like nova > with a better deserialize that will (I think) do the same thing here. > If I'm not mistaken we will still have to change the plugins so if we > decide to go with his proposal we'll have to do this work anyways. > > Also note that I didn't change the cisco plugins yet .. but I will. I > just wanted to see if people are OK with this before I go and do that > since it is fairly time consuming. Must be the shear number of tests! > that is a good reason for a task to be time consuming :) dan > > Thanks, > Brad > > -- > Mailing list: https://launchpad.net/~netstack > Post to : netstack@lists.launchpad.net > Unsubscribe : https://launchpad.net/~netstack > More help : https://help.launchpad.net/ListHelp > -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks, Inc. www.nicira.com | www.openvswitch.org Sr. Product Manager cell: 650-906-2650 ~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
