Hi Dan,
I have looked at the changes and they seem to be fine. Thanks for taking care of this. We will need to do more testing on this, and there are other changes as well for which we will propose a merge soon from another branch. Until then, this is fine on the trunk. Since the branch was already merged (thanks Brad J), I could not +1/2, but I added a comment. Thanks, ~Sumit. From: netstack-bounces+snaiksat=cisco....@lists.launchpad.net [mailto:netstack-bounces+snaiksat=cisco....@lists.launchpad.net] On Behalf Of Dan Wendlandt Sent: Saturday, October 15, 2011 9:59 PM To: Brad Hall Cc: netstack@lists.launchpad.net Subject: Re: [Netstack] Review approval protocol (gerrit) The net result is that the pep8 fixes I mentioned in my previous email on in trunk already. In one way, this is a good thing, as it means that we can procede integrating other fixes into trunk as well. On the other hand, it means my untested changes to the cisco plugin are in trunk, so it would be great if someone from the cisco team could test it out ASAP to see if there were any regressions (we can always just revert). Dan On Sat, Oct 15, 2011 at 9:39 PM, Brad Hall <b...@nicira.com> wrote: As the first one to completely mess this up (I clicked approve on a review (+2) when there wasn't a (+1) yet) I figured I'd send out a link describing the protocol in case anyone other than me missed this in the documentation. >From http://wiki.openstack.org/GerritJenkinsGithub: Any Openstack developer may propose or comment on a change (including voting +1/0/-1 on it). A vote of +2 is allowed from core reviewers, but should only be used after another core member has voted +1 and there are no outstanding -1 votes. If you're coming from Launchpad, a +2 vote is equivalent to setting a merge prop status to "Approved". OpenStack projects have a policy of requiring two core reviewers to approve a patch. Once a review receives one +2 vote, Jenkins will run the proposed change and verify the merge. If Jenkins successfully tests the change, and there are no -2 code review votes, the change will be automatically merged into the repository. ... The result of this is that if you +2 something before anyone else reviewed it, it will just get submitted which violates our 2-reviewer policy. Ooops. Sorry about that.. Thanks, Brad -- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks, Inc. www.nicira.com | www.openvswitch.org Sr. Product Manager cell: 650-906-2650 ~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
